src/views/organisations/dataset-overview.html (2)

137-148: Consider simplifying the falsy check for documentation_url.

The current check is not defined or endpoint.documentation_url == "" may not catch null values. In Nunjucks, you can use a simpler falsy check:

♻️ Suggested simplification

-    {% if endpoint.documentation_url is not defined or endpoint.documentation_url == "" %}
+    {% if not endpoint.documentation_url %}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/views/organisations/dataset-overview.html` around lines 137 - 148, The
template currently checks "endpoint.documentation_url is not defined or
endpoint.documentation_url == ''" which misses null/other falsy values; replace
that conditional with a single falsy check (e.g., "if not
endpoint.documentation_url") to cover undefined, null, and empty string, leaving
the endpointRows.push usage and the else branch that builds the anchor (using
urlStyle and endpoint.documentation_url) unchanged so the error markup and link
rendering remain identical.

---

13-20: Macro always renders error message regardless of error state.

The endpointUrlInfo macro unconditionally renders the error message block (lines 16-18). While current usage at line 127 is guarded by {% if endpoint.error %}, the macro name doesn't indicate it's error-specific, which could lead to misuse if called elsewhere.

Consider either:

1. Renaming to endpointUrlWithError to clarify intent, or
2. Adding a guard within the macro

♻️ Option 2: Add guard within macro

 {% macro endpointUrlInfo(organisation, dataset, endpoint) %}
   <a style="{{ urlStyle}}" href="{{endpoint.endpoint_url}}">{{endpoint.endpoint_url}}</a>
-
-  <p class="govuk-error-message">
-   {{ endpointErrorMessage(endpoint) }}
-  </p>
-
+  {% if endpoint.error %}
+    <p class="govuk-error-message">
+      {{ endpointErrorMessage(endpoint) }}
+    </p>
+  {% endif %}
 {% endmacro %}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/views/organisations/dataset-overview.html` around lines 13 - 20, The
macro endpointUrlInfo currently always renders the error block; update the macro
so the error message paragraph (the call to endpointErrorMessage(endpoint)) is
only rendered when endpoint.error is truthy by wrapping that <p> block with a
conditional (e.g., {% if endpoint.error %} ... {% endif %}); keep the macro name
or optionally rename to endpointUrlWithError if you prefer an explicit name, but
ensure endpointUrlInfo only outputs the error markup when endpoint.error is set.

✅ Autofix completed

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/views/organisations/dataset-overview.html (1)

13-20: Minor: Inconsistent spacing in template variable syntax.

The spacing within Nunjucks template variables is inconsistent. Line 14 uses {{ urlStyle}} and {{endpoint.endpoint_url}} whilst other parts of the template use consistent spacing like {{ urlStyle }}.

This is a minor style nit but worth keeping consistent for readability.

♻️ Suggested fix for consistency

 {% macro endpointUrlWithError(organisation, dataset, endpoint) %}
-  <a style="{{ urlStyle}}" href="{{endpoint.endpoint_url}}">{{endpoint.endpoint_url}}</a>
+  <a style="{{ urlStyle }}" href="{{ endpoint.endpoint_url }}">{{ endpoint.endpoint_url }}</a>
 
   <p class="govuk-error-message">
    {{ endpointErrorMessage(endpoint) }}
   </p>
 
 {% endmacro %}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/views/organisations/dataset-overview.html` around lines 13 - 20, The
template macro endpointUrlWithError has inconsistent Nunjucks variable spacing;
update all mustache tags inside that macro to use consistent spacing (e.g., "{{
urlStyle }}", "{{ endpoint.endpoint_url }}", "{{ endpointErrorMessage(endpoint)
}}") so every template variable follows the same "{{ var }}" style—edit the
occurrences of urlStyle, endpoint.endpoint_url, and endpointErrorMessage within
the endpointUrlWithError macro to apply the spaced format.